Fix evolution logic #870
Merged
Fix evolution logic #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EvolveAllPokemonAboveIv and EvolveAllPokemonWithEnoughCandy configs share the same task yet do not properly differentiate between the two in the logic.
The logic is now as follows:
If EvolveAllPokemonWithEnoughCandy only true, then it will evolve all in PokemonsToEvolve list.
If EvolveAllPokemonAboveIv only true, then only those above the threshold will be evolved.
If both, evolves all in list and those above the threshold.
This should resolve #810 and #816.
I have also implemented #763, where an empty PokemonsToEvolve list evolves all eligible pokemon.